Skip to content

fix switched-round 'b' and 'c' #27418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2015
Merged

fix switched-round 'b' and 'c' #27418

merged 1 commit into from
Jul 31, 2015

Conversation

taliesinb
Copy link

this makes the second code block consistent with the first code block -- other than being in reversed order, the first code block claims b is u16 and c is u32, whereas the second code block claims the opposite. seems to be an obvious typo.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@taliesinb
Copy link
Author

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Jul 31, 2015
@taliesinb
Copy link
Author

Do even small doc point fixes trigger a full CI test cycle? Or did I do something wrong? I feel bad now. So many wasted joules.

@alexcrichton
Copy link
Member

@bors: r+ b36890b

Thanks!

@Gankra
Copy link
Contributor

Gankra commented Jul 31, 2015

@taliesinb If you don't want to trigger travis you can add [ci skip] to your commit -- although this is often useful to us anyway since it catches style errors that will cause the PR to bounce in our own CI system (wasting even more resources).

@Gankra
Copy link
Contributor

Gankra commented Jul 31, 2015

@taliesinb I feel obligated to note that I plan to submit this document as my Masters Thesis in January.

Are you ok with your work being used for this purpose?

@taliesinb
Copy link
Author

@gankro thanks for the tip.

and of course, though thank you for asking. i hope to actually have more interesting contributions that would offset the effort of even asking that question :-)

@bors
Copy link
Collaborator

bors commented Jul 31, 2015

⌛ Testing commit b36890b with merge b1b7f66...

@bors
Copy link
Collaborator

bors commented Jul 31, 2015

💔 Test failed - auto-linux-32-opt

@Gankra
Copy link
Contributor

Gankra commented Jul 31, 2015

@bors retry

@bors
Copy link
Collaborator

bors commented Jul 31, 2015

⌛ Testing commit b36890b with merge 89bc9fa...

bors added a commit that referenced this pull request Jul 31, 2015
this makes the second code block consistent with the first code block -- other than being in reversed order, the first code block claims b is u16 and c is u32, whereas the second code block claims the opposite. seems to be an obvious typo.
@bors bors merged commit b36890b into rust-lang:master Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants