-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix switched-round 'b' and 'c' #27418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Do even small doc point fixes trigger a full CI test cycle? Or did I do something wrong? I feel bad now. So many wasted joules. |
@taliesinb If you don't want to trigger travis you can add |
@taliesinb I feel obligated to note that I plan to submit this document as my Masters Thesis in January. Are you ok with your work being used for this purpose? |
@gankro thanks for the tip. and of course, though thank you for asking. i hope to actually have more interesting contributions that would offset the effort of even asking that question :-) |
⌛ Testing commit b36890b with merge b1b7f66... |
💔 Test failed - auto-linux-32-opt |
@bors retry |
⌛ Testing commit b36890b with merge 89bc9fa... |
this makes the second code block consistent with the first code block -- other than being in reversed order, the first code block claims b is u16 and c is u32, whereas the second code block claims the opposite. seems to be an obvious typo.
this makes the second code block consistent with the first code block -- other than being in reversed order, the first code block claims b is u16 and c is u32, whereas the second code block claims the opposite. seems to be an obvious typo.