add diagnostics for E0387 #27605
Merged
add diagnostics for E0387 #27605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! |
|
I'd like to see some tips for cases where the function definition is not owned by the user too. Something that hints the usage of interior mutability (std::cell) would be nice. r+ as-is is also fine by me |
|
Thanks! I'm not exactly firing on all cylinders, but hoping to get things done here and there :-). Good point on the use of cell, that actually hadn't crossed my mind. I'll add it in. |
|
Added info about cell types! |
|
|
||
| ``` | ||
| fn mutable() { | ||
| let x = std::cell::Cell::new(0u32); |
There was a problem hiding this comment.
nit: just use import std::cell::Cell; at the top, long paths look ugly inline
|
@bors r+ rollup |
|
📌 Commit f041966 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 11, 2015
…arth As title :-) Part of rust-lang#24407. r? @Manishearth
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Aug 12, 2015
As title :-) Part of rust-lang#24407. r? @Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title :-)
Part of #24407.
r? @Manishearth