Codegen for ports and channels #279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustc, but not in rustboot
|
Integrated. |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
unix: Add PIPE_BUF for bsd and notbsd This is the maximum size of guaranteed-atomic writes to a pipe.
kazcw
pushed a commit
to kazcw/rust
that referenced
this pull request
Oct 23, 2018
* Migrate `i686::sse` to vendor types * Migrate `i686::sse2` to vendor types * Migrate i686::sse41 to vendor types * Migrate i686::sse42 to vendor types
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Oct 26, 2020
djtech-dev
pushed a commit
to djtech-dev/rust
that referenced
this pull request
Dec 9, 2021
Added new GH actions CI
antoyo
added a commit
to antoyo/rust
that referenced
this pull request
Jun 19, 2023
Regen intrinsics with latest LLVM version
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
…ust-lang#279) * Correct check for vtable pointer type * Comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set implements code generation for ports and channels. I think this is all pretty nice - the only thing I'm really concerned about is the refcounting. From what I can tell the refcounts are working correctly; I just don't exactly understand why. I expected trans_recv to require a cleanup for the received data but it has thus far rejected my efforts to do so.
I'm beginning to understand what's going on in trans.rs, but please give it a close look and see if there's anything I can improve.
Next is implementing local declarations with receive, e.g. "let int x <- p", then on to spawning tasks.