Add line numbers to MSVC backtrace #28242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -15,7 +15,8 @@ pub fn callback<F>(f: F) where F: FnOnce((&'static str, u32)) { | |||
| f((file!(), line!())) | |||
| } | |||
|
|
|||
| #[inline(always)] | |||
| #[cfg_attr(not(target_env = "msvc"), inline(always))] | |||
| #[cfg_attr(target_env = "msvc", inline(never))] | |||
There was a problem hiding this comment.
Could you add a comment explaining what's going on here?
|
Awesome, thanks @Diggsey! I had implemented this in backtrace-rs but apparently forgot to port it over! |
Add comments
Diggsey
force-pushed
the
msvc-backtrace
branch
from
f0279e7 to
9a83842
Compare
|
All done! |
|
⌛ Testing commit 9a83842 with merge 6b36e92... |
bors
added a commit
that referenced
this pull request
Sep 5, 2015
Currently LLVM does not generate the debug info required to get complete backtraces even when functions are inlined, so that part of the `run-pass/backtrace-debuginfo.rs` test is disabled when targetting MSVC. At worst this results in missing stack frames where functions have been inlined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently LLVM does not generate the debug info required to get complete backtraces even when functions are inlined, so that part of the
run-pass/backtrace-debuginfo.rstest is disabled when targetting MSVC. At worst this results in missing stack frames where functions have been inlined.