Add new error codes on privacy checking #28312
Conversation
| ``` | ||
|
|
||
| To solve this error, please ensure the trait is accessible at the same level of | ||
| the type(s) on which it's implemented. Example: |
There was a problem hiding this comment.
ensure that the trait is also public and accessible at the same level of the public functions or types which are bound on it.
GuillaumeGomez
force-pushed
the
privacy
branch
from
5b8d29c to
42e1622
Compare
|
Updated ! |
GuillaumeGomez
force-pushed
the
privacy
branch
from
068b727 to
bda7ec0
Compare
|
It should be good (for now !). |
GuillaumeGomez
force-pushed
the
privacy
branch
2 times, most recently
from
f1dfa7a to
5d18544
Compare
|
I added the other examples of erroneous code. |
GuillaumeGomez
force-pushed
the
privacy
branch
from
5d18544 to
dfd6963
Compare
| } | ||
| ``` | ||
|
|
||
| Since we cannot access inside function's elements, the visibility of its |
There was a problem hiding this comment.
we cannot access items defined inside a function, the visibility of its items does ...
GuillaumeGomez
force-pushed
the
privacy
branch
from
dfd6963 to
5c21a43
Compare
|
Updated ! |
| To fix this error, please remove the visibility qualifier when it is not | ||
| required. Also, directly implemented methods share the visibility of the type | ||
| itself and trait methods share the visibility of the trait, so `pub` is | ||
| unnecessary in either case. |
There was a problem hiding this comment.
This should go before the fix. Explain the problem first, then the solution.
Something like
"Directly implemented methods .... in either case.
To fix this error, ..."
GuillaumeGomez
force-pushed
the
privacy
branch
from
5c21a43 to
0477976
Compare
|
Updated ! |
|
@bors r+ rollup |
|
📌 Commit 0477976 has been approved by |
|
⌛ Testing commit 0477976 with merge 942377e... |
|
⛄ The build was interrupted to prioritize another pull request. |
r? @Manishearth