Emit an error upon failing to create a temp dir instead of panicking #28430
Conversation
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
(It'd be great if the commit message described what it was doing, instead of being entirely dependent on the issue.) |
apasel422
changed the title
apasel422
changed the title
|
I'll take the liberty of copying the PR title into the PR description since it seems like our homu instance does not have the fix for barosl/homu#65 |
| -include ../tools.mk | ||
|
|
||
| all: | ||
| TMPDIR=fake $(RUSTC) foo.rs 2>&1 | grep "couldn't create a temp dir:" |
There was a problem hiding this comment.
One might argue that this is not actually testing the real meat of the PR -- to do that I'd say you would want to grep for fake too.
but that is such a minor nit that I am not going to hold up this PR on it
There was a problem hiding this comment.
The error message doesn't necessarily include the name of the temp dir itself.
|
@bors r+ 189595d rollup |
|
⌛ Testing commit 189595d with merge eb2b792... |
|
💔 Test failed - auto-win-gnu-64-nopt-t |
|
I'm not sure what to make of the error from auto-win-gnu-64-nopt-t. |
|
Actually, this is probably a result of Windows using |
|
r? @pnkfelix This should work on Windows now. |
|
Can someone have @bors retry this? |
Emit an error upon failing to create a temp dir instead of panicking Closes rust-lang#14698.
Emit an error upon failing to create a temp dir instead of panicking
Closes #14698.