Various rustbook improvements #28649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly indentation fixes, but a little refactoring, too.
There's no need for javascript.rs now that its contents were moved into .js files. Also, adjust a couple variable names and some indentation in build.rs.
This should fix #22682. "max-width: 1023px" seems like a good compromise here. This way, 1024x768 monitors will still see the sidebar (plus, iPad in landscape mode).
|
Looks good to me, thanks! |
|
@bors: r+ |
|
📌 Commit 0bebbab has been approved by |
bors
added a commit
that referenced
this pull request
Sep 26, 2015
Please see the commits for details. Live demo: http://www.nickhowell.com/rust/book/ Commit 0bebbab should fix #22682 r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commits for details.
Live demo: http://www.nickhowell.com/rust/book/
Commit 0bebbab should fix #22682
r? @steveklabnik