Skip to content

Contrib doc #28815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2015
Merged

Contrib doc #28815

merged 2 commits into from
Oct 3, 2015

Conversation

matklad
Copy link
Member

@matklad matklad commented Oct 2, 2015

This adds a paragraph on how to generate documentation without sloooow make doc. I'm not a native English speaker, so there might be some language related bugs (I wish English was as hard to get wrong, as Rust)

This also includes whitespace cleanup of contributing.md in a separate commit. Whiltespace is not significant in github flavored markdown, and my Emacs just cleans ws automatically :)

r? @steveklabnik


[adocs]: https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AA-docs

To render documentation you can use rustdoc. For example, `rustdoc
src/doc/reference.md` will render reference to `doc/reference.html`. The css
might be messed up, but you can verify that html is right.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

The English is great. 😄 A few things:

  • rustdoc should be in graves, so it renders like code.
  • CSS and HTML not css and html
  • Can you add something to indicate that this might not always work? Something like

In many cases, you don't need a full make doc. You can use rustdoc directly to check small fixes. For example...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK now. Should I squash the last two commits?

@steveklabnik
Copy link
Member

Yes please!

@matklad
Copy link
Member Author

matklad commented Oct 3, 2015

rebased

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 3, 2015

📌 Commit c3753ce has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Oct 3, 2015

⌛ Testing commit c3753ce with merge 4665aae...

bors added a commit that referenced this pull request Oct 3, 2015
This adds a paragraph on how to generate documentation without sloooow `make doc`. I'm not a native English speaker, so there might be some language related bugs (I wish English was as hard to get wrong, as Rust)

This also includes whitespace cleanup of contributing.md in a separate commit. Whiltespace is not significant in github flavored markdown, and my Emacs just cleans ws automatically :)

r? @steveklabnik
@bors bors merged commit c3753ce into rust-lang:master Oct 3, 2015
@matklad matklad deleted the contrib-doc branch July 9, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants