Clean newlines #28864
Clean newlines #28864
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ rollup |
|
📌 Commit 3967e1c has been approved by |
|
Thank you! |
|
⌛ Testing commit 3967e1c with merge 0d59012... |
Sorry I didn’t get this in the last PR (#28864), I hadn’t thought of it.
|
@bors: r+ rollup |
|
📌 Commit aba267f has been approved by |
Remove leading newlines in files and replace lines containing only whitespace with blank lines
| @@ -1,7 +1,7 @@ | |||
| // ignore-tidy-cr ignore-license | |||
| // ignore-tidy-cr (repeated again because of tidy bug) | |||
| // license is ignored because tidy can't handle the CRLF here properly. | |||
|
|
|||
There was a problem hiding this comment.
No! Not this file! This test is specifically supposed to use crlf! This is changing the blank lines from \r\n to \n!
There was a problem hiding this comment.
Ahhhhh eff. @Aarzee can you send a PR fixing this?
|
If @Aarzee can't do this soon, I will fix it tomorrow. Of course I missed one 👎 |
|
Sorry, didn't realize this was wrong. I don't think I'll be able to fix this tonight/tomorrow as I've got a couple obligations involving limited Internet access. :(
|
|
No worries! I'll do it right now then. |
In rust-lang#28864, @Aarzee submitted some whitespace fixes. I r+'d it. But @retp998 noticed[1] that this file is explicitly a test of this kind of whitespace, and so I shouldn't have changed it. This restores the old line endings. 1: rust-lang#28864 (comment)
|
Sent: #28876 |
In rust-lang#28864, @Aarzee submitted some whitespace fixes. I r+'d it. But @retp998 noticed[1] that this file is explicitly a test of this kind of whitespace, and so I shouldn't have changed it. This restores the old line endings. 1: rust-lang#28864 (comment)
In rust-lang#28864, @Aarzee submitted some whitespace fixes. I r+'d it. But @retp998 noticed[1] that this file is explicitly a test of this kind of whitespace, and so I shouldn't have changed it. This restores the old line endings. 1: rust-lang#28864 (comment)
Remove leading newlines in files and replace lines containing only whitespace with blank lines