Skip to content

rustfmt some submodules of libcore #28896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2015
Merged

rustfmt some submodules of libcore #28896

merged 3 commits into from
Oct 8, 2015

Conversation

mkpankov
Copy link
Contributor

@mkpankov mkpankov commented Oct 7, 2015

Review on Reviewable

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mkpankov
Copy link
Contributor Author

mkpankov commented Oct 7, 2015

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned brson Oct 7, 2015
nrc
nrc reviewed Oct 7, 2015
View reviewed changes
src/libcore/fmt/num.rs
if x == zero { break }; // No more digits left to accumulate.
if x == zero {
break
}; // No more digits left to accumulate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manually fix the above change but not this one? If not then it is probably a weird bug in rustfmt. In any case, could you fixup this comment too please?

@nrc
Copy link
Member

nrc commented Oct 7, 2015

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 7, 2015

📌 Commit 11a7773 has been approved by nrc

@nrc
Copy link
Member

nrc commented Oct 7, 2015

Thanks for the PR!

@mkpankov
Copy link
Contributor Author

mkpankov commented Oct 7, 2015

😃

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 7, 2015
@steveklabnik
Rollup merge of rust-lang#28896 - mkpankov:core-fmt, r=nrc
0fbf7ea 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/rust-lang/rust/28896)
<!-- Reviewable:end -->
@steveklabnik steveklabnik mentioned this pull request Oct 7, 2015
Merged
alexcrichton
alexcrichton reviewed Oct 7, 2015
View reviewed changes
src/libcore/fmt/num.rs
if x == zero {
// No more digits left to accumulate.
break
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nrc, perhaps rustfmt could auto-remove these semicolons?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could and it should! https://github.com/nrc/rustfmt/issues/422

bors added a commit that referenced this pull request Oct 8, 2015
@bors
Auto merge of #28897 - steveklabnik:rollup, r=steveklabnik
b75fe81 
- Successful merges: #28836, #28856, #28874, #28876, #28878, #28880, #28882, #28885, #28889, #28896
- Failed merges:
@bors bors merged commit 11a7773 into rust-lang:master Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mkpankov @rust-highfive @nrc @bors @alexcrichton @brson