Write better module-level docs for std::iter #28914
Conversation
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -8,51 +8,278 @@ | |||
| // option. This file may not be copied, modified, or distributed | |||
| // except according to those terms. | |||
|
|
|||
| //! Composable external iterators | |||
| //! Composable external iteratoration | |||
There was a problem hiding this comment.
Spelling mistake here? "iteratoration"
steveklabnik
force-pushed
the
doc_iterator
branch
from
1622c9a to
0f8b000
Compare
|
Updated! |
steveklabnik
force-pushed
the
doc_iterator
branch
from
0f8b000 to
d06c2db
Compare
|
So, I rendered these locally to check all the links, but I'm getting a JavaScript error: I'm not modifying any JS here... so I'm confused. any ideas? |
|
re-building made that go away. No clue. |
steveklabnik
force-pushed
the
doc_iterator
branch
from
d06c2db to
e412955
Compare
|
This is good to go 👍 |
| //! | ||
| //! # The `Iterator` trait | ||
| //! If you've found yourself with a collection of some kind, and needed to perform an operation on |
There was a problem hiding this comment.
"obligatory 80 char reminder"
|
Wow super nice docs, thanks @steveklabnik! |
steveklabnik
force-pushed
the
doc_iterator
branch
from
e412955 to
2f9f263
Compare
|
Updated! |
This replaces what was there with a comprehensive overview. Thanks to @Hoverbear for suggesting that these docs needed improvement.
|
💔 Test failed - auto-mac-64-opt |
steveklabnik
force-pushed
the
doc_iterator
branch
from
2f9f263 to
1fbf8bb
Compare
This replaces what was there with a comprehensive overview. Thanks to @Hoverbear for suggesting that these docs needed improvement.
This replaces what was there with a comprehensive overview.
|
a whitespace snuck in at the end 😭 |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry |
|
⚡ Previous build results for auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-64-opt... |
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors: retry On Mon, Oct 12, 2015 at 9:44 AM, bors [email protected] wrote:
|
|
⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-x-android-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-64-opt... |
|
@bors: r=alexcrichton |
|
ah, so this was merged. cool. |
This replaces what was there with a comprehensive overview.
Thanks to @Hoverbear for suggesting that these docs needed improvement.