save-analysis: normalise node ids before emitting. #29040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| fn normalize_node_id(&self, id: NodeId) -> usize { |
There was a problem hiding this comment.
Nit: I think the purpose of this function merits a comment.
|
r+ with a comment indicating what purpose |
With this change, normalised node ids correspond to def id indices where they exist, or are made disjoint from def ids otherwise.
|
📌 Commit 06b5a95 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 15, 2015
With this change, normalised node ids correspond to def id indices where they exist, or are made disjoint from def ids otherwise. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, normalised node ids correspond to def id indices where they exist, or are made disjoint from def ids otherwise.
r? @nikomatsakis