-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Use Travis trusty infrastructure #29159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I can't test this myself since my own account has a 50 minute build time limit, but generally docker just seemed kind of redundant even if it only maybe adds a few minutes to the build time. With Rust's special travis settings hopefully it builds! Also, considering that travis has been blocked up for a while, someone might want to cancel these bors commit tests to help travis catch up to all PRs in a decent time. |
Hm so on one hand I kinda like using docker because it makes the builds very easily reproducible as well as clearly showing us what our dependencies are (I think the Travis images come with some extra goodies by default), but on the other hand it does seem like it may just be unnecessary here. I'm fine merging, just waiting on travis to report back! |
Makes sense, I also considered the same thing (and wondered if I should keep the dockerfile around just in case). Travis does have a minimal image though, which should help with that concern. I'll give it a try after this queued build hits. |
You can use the |
More info here |
Ah right, I was doing that on the container infrastructure but moved to the commands on GCE. I'll see about reverting that back again. EDIT: it doesn't look like the sources we need are whitelisted. Just pushed a version that uses the minimal GCE image instead. |
While we're at it, can we remove or revise "Real testing happens on http://buildbot.rust-lang.org/" comment? It was introduced in #26224 when Travis only ran "make tidy", therefore no real testing. Maybe "Testing also happens" etc. |
Well, it's still correct in that buildbot tests all supported platforms while Travis only tests x86_64 Linux. It's at best supplemental smoke testing, though I'm open to suggestions for a better explanation there. |
OK looks like this passed just fine, so I'd be fine merging with the |
I wasn't able to get the |
⌛ Testing commit 1181ca4 with merge b69c39c... |
@bors: retry force |
Moves back away from docker but still uses the GCE infrastructure with a system-installed LLVM. See http://docs.travis-ci.com/user/trusty-ci-environment/
Moves back away from docker but still uses the GCE infrastructure with a system-installed LLVM.
See http://docs.travis-ci.com/user/trusty-ci-environment/