run rustfmt on std::path #29200
Merged
run rustfmt on std::path #29200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| VerbatimUNC(x,y) => 8 + os_str_len(x) + | ||
| if os_str_len(y) > 0 { 1 + os_str_len(y) } | ||
| else { 0 }, | ||
| VerbatimUNC(x, y) => 8 + os_str_len(x) + |
There was a problem hiding this comment.
Ughh, rustfmt doesn't do inline if-else expressions well. I'd personally refactor this to use an intermediate value.
There was a problem hiding this comment.
I changed that into a block instead... it's more readable, and gets formatted better by rustfmt.
There was a bunch of manual fixes too... rustfmt isn't quite there yet
|
📌 Commit 37735b4 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Nov 4, 2015
bors
added a commit
that referenced
this pull request
Nov 4, 2015
|
no problem, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.