std: Refactor process exit code handling slightly #29462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 76fb2f5 has been approved by |
|
⌛ Testing commit 76fb2f5 with merge 9798c14... |
|
💔 Test failed - auto-win-msvc-64-opt |
alexcrichton
force-pushed
the
refactor-process-ret
branch
from
76fb2f5 to
bd032ba
Compare
|
@bors: r=aturon bd032ba |
|
⌛ Testing commit bd032ba with merge f561cdf... |
|
💔 Test failed - auto-win-msvc-32-opt |
* Store the native representation directly in the `ExitStatus` structure instead of a "parsed version" (mostly for Unix). * On Windows, be more robust against processes exiting with the status of 259. Unfortunately this exit code corresponds to `STILL_ACTIVE`, causing libstd to think the process was still alive, causing an infinite loop. Instead the loop is removed altogether and `WaitForSingleObject` is used to wait for the process to exit.
alexcrichton
force-pushed
the
refactor-process-ret
branch
from
bd032ba to
94aee5b
Compare
bors
added a commit
that referenced
this pull request
Nov 6, 2015
* Store the native representation directly in the `ExitStatus` structure instead of a "parsed version" (mostly for Unix). * On Windows, be more robust against processes exiting with the status of 259. Unfortunately this exit code corresponds to `STILL_ACTIVE`, causing libstd to think the process was still alive, causing an infinite loop. Instead the loop is removed altogether and `WaitForSingleObject` is used to wait for the process to exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExitStatusstructure insteadof a "parsed version" (mostly for Unix).
Unfortunately this exit code corresponds to
STILL_ACTIVE, causing libstd tothink the process was still alive, causing an infinite loop. Instead the loop
is removed altogether and
WaitForSingleObjectis used to wait for theprocess to exit.