rustdoc: Accept tabs as indentation character #29495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cmr (rust_highfive has picked a reviewer for you, use r? to override) |
|
Well, that's embarrassing. I didn't notice a call to The way I see it, there are two options:
I'm not entirely sure what would be best. |
|
I'm tempted to just say trim all whitespace. |
|
That's fine by me. I updated the fix and the tests. Give me the signal and I'll squash the commits. |
|
Let's do it. r=me after a squash |
A line may be indented with both spaces or tabs. All leading whitespace is trimmed, even if it is mixed.
|
It's done. Thank you, @steveklabnik. |
|
@bors: r+ |
|
📌 Commit a9cbf6c has been approved by |
bors
added a commit
that referenced
this pull request
Nov 3, 2015
A line may be indented with either spaces or tabs, but not a mix of both. If there is a mix of tabs and spaces, only the kind that occurs first is counted. This addresses issue #29268.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A line may be indented with either spaces or tabs, but not a mix of both. If there is a mix of tabs and spaces, only the kind that occurs first is counted.
This addresses issue #29268.