Implement From and PartialEq for Path, PathBuf and Cow<Path> combinations #29532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @aturon Not sure if these are unimplemented intentionally? (couldn't find any previous issues in the tracker) |
|
☔ The latest upstream changes (presumably #29514) made this pull request unmergeable. Please resolve the merge conflicts. |
| #[stable(feature = "partialeq_path", since = "1.6.0")] | ||
| impl<'a, 'b> PartialEq<$rhs> for $lhs { | ||
| #[inline] | ||
| fn eq(&self, other: &$rhs) -> bool { self.components().eq(other.components()) } |
There was a problem hiding this comment.
Could this delegate to the <Path as PartialEq>::eq implementation instead of re-encoding the same one here? It's also probably fine to omit ne for now as it's not specialized in the main impl either.
|
Nah these weren't intentionally left out or anything, they should be good to go! |
|
@alexcrichton Updated! |
bors
added a commit
that referenced
this pull request
Nov 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.