Skip to content

Add rustc UX guidelines. #29687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2015
Merged

Add rustc UX guidelines. #29687

merged 1 commit into from
Nov 25, 2015

Conversation

Havvy
Copy link
Contributor

@Havvy Havvy commented Nov 8, 2015

See rust-lang/rfcs#1246 for discussion.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@Havvy Havvy changed the title Add rustx UX guidelines. Add rustc UX guidelines. Nov 8, 2015
@brson
Copy link
Contributor

brson commented Nov 11, 2015

I don't have an opinion about whether to add this, or the contents, but the doc directory is for user documentation, and it is converted to html and published. This does not look like that kind of documentation. I don't have a better suggestion of where to put it offhand, but it seems like wiki material to me.

cc @rust-lang/compiler

r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned brson Nov 11, 2015
@tshepang
Copy link
Member

Maybe make it part of CONTRIBUTING.md

@Havvy
Copy link
Contributor Author

Havvy commented Nov 12, 2015

It shouldn't be inside CONTRIBUTING.md, but there should be a link to it from there.

@nikomatsakis
Copy link
Contributor

Dev dungeon!
On Nov 11, 2015 6:25 PM, "Brian Anderson" [email protected] wrote:

I don't have an opinion about whether to add this, or the contents, but
the doc directory is for user documentation, and it is converted to html
and published. This does not look like that kind of documentation. I don't
have a better suggestion of where to put it offhand, but it seems like wiki
material to me.

cc @rust-lang/compiler https://github.com/orgs/rust-lang/teams/compiler

r? @pnkfelix https://github.com/pnkfelix


Reply to this email directly or view it on GitHub
#29687 (comment).

@Havvy
Copy link
Contributor Author

Havvy commented Nov 20, 2015

So, what's actually blocking on this?

Final Comment Period for the RFC?

Choosing which directory to put this file?

@nrc
Copy link
Member

nrc commented Nov 22, 2015

@Havvy where to put it - in particular it seems unclear who is going to make that decision :-(

@pnkfelix
Copy link
Member

Well, what's really blocking it is that it was assigned to me and I need to bother to write r+ ... honestly, we can always move it somewhere else if a better location presents itself.

@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 24, 2015

📌 Commit 13b7b07 has been approved by pnkfelix

@pnkfelix
Copy link
Member

@bors rollup

@bors
Copy link
Collaborator

bors commented Nov 25, 2015

⌛ Testing commit 13b7b07 with merge 5faed4c...

bors added a commit that referenced this pull request Nov 25, 2015
@bors bors merged commit 13b7b07 into rust-lang:master Nov 25, 2015
@Havvy
Copy link
Contributor Author

Havvy commented Nov 25, 2015

❤️ 💚 💛 💙 💜

@Havvy Havvy deleted the ux-guidelines branch September 27, 2017 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants