Skip to content

valgrind: update suppressions and move interesting tests #29699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2015

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Nov 8, 2015

Quite a bit of cruft in the valgrind suppressions. I started from a clean slate and found a few unique failures; this commit also moves the tests "fixed" by these suppressions into run-pass-valgrind.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ c21ffc2

Thanks!

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

🙀 c21ffc27b12f092c8fd0789266aefff7796a73b5 is not a valid commit SHA. Please try again with 269a811.

@tamird
Copy link
Contributor Author

tamird commented Nov 9, 2015

Heh, what's up with bors?

@tamird
Copy link
Contributor Author

tamird commented Nov 9, 2015

@alexcrichton ah, sorry the commits are not rendering in the correct order on this branch. @bors is correct that 269a811 is the one you want.

@alexcrichton
Copy link
Member

@bors: r+ 269a811

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

⌛ Testing commit 269a811 with merge 26b3204...

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

💔 Test failed - auto-win-msvc-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Nov 9, 2015 at 11:02 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/2011


Reply to this email directly or view it on GitHub
#29699 (comment).

@bors
Copy link
Collaborator

bors commented Nov 10, 2015

⌛ Testing commit 269a811 with merge 4afa9d9...

bors added a commit that referenced this pull request Nov 10, 2015
Quite a bit of cruft in the valgrind suppressions. I started from a clean slate and found a few unique failures; this commit also moves the tests "fixed" by these suppressions into run-pass-valgrind.
@bors bors merged commit 269a811 into rust-lang:master Nov 10, 2015
@tamird tamird deleted the valgrind-supp branch November 10, 2015 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants