Add E0517, E0518 for repr() errors #29716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| discriminant size for C-like enums (i.e., no data), effectively setting the | ||
| entire size to the same type. Such an enum can be cast to a value of the same | ||
| type as well. In short, `#[repr(u8)]` makes the enum behave like an integer with | ||
| constrained set of allowed values. |
There was a problem hiding this comment.
s/constrained set/a constrained set/
Manishearth
force-pushed
the
repr-error
branch
from
b016333 to
76d3732
Compare
| type Foo = u8; | ||
|
|
||
| #[repr(packed)] | ||
| enum Foo {Bar, Baz} |
There was a problem hiding this comment.
Oh whoah. Curly brace enums without field names.
There was a problem hiding this comment.
❓ enums always have curly braces?
There was a problem hiding this comment.
Man, how tired was I?
I though this was enum Foo { Foo { Bar, Baz } }
Manishearth
force-pushed
the
repr-error
branch
2 times, most recently
from
9f25ce9 to
c03048f
Compare
|
Updated. |
Manishearth
force-pushed
the
repr-error
branch
from
c03048f to
92df8a9
Compare
|
@bors r+ |
|
📌 Commit 92df8a9 has been approved by |
|
@bors rollup |
bors
added a commit
that referenced
this pull request
Nov 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @gankro