Skip to content

change link on book front page trpl -> book #29966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2015
Merged

change link on book front page trpl -> book #29966

merged 1 commit into from
Nov 21, 2015

Conversation

MatthiasKauer
Copy link
Contributor

This commit changes the location of the rust docs.
024aa9a
Clicking the contribution link on the front page therefore becomes a 'not found' error.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Oops, thanks!

On Nov 20, 2015, 18:56 -0500, Rust highfive [email protected], wrote:

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from@nikomatsakis(https://github.com/nikomatsakis)(or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please seethe contribution instructions(https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md)for more information.


Reply to this email directly orview it on GitHub(#29966 (comment)).

@bors
Copy link
Collaborator

bors commented Nov 21, 2015

📌 Commit e37cd6d has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Nov 21, 2015

⌛ Testing commit e37cd6d with merge 685e098...

bors added a commit that referenced this pull request Nov 21, 2015
This commit changes the location of the rust docs.
024aa9a
Clicking the contribution link on the front page therefore becomes a 'not found' error.
@danmactough
Copy link

How does this get deployed? The public website still has the wrong link. 😢

image

@steveklabnik
Copy link
Member

changes to stable come out at most 12 weeks after, since the docs are versioned. It will be fixed as of the next release.

@danmactough
Copy link

Gotcha. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants