Skip to content

Fix spans for macros #30075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2015
Merged

Fix spans for macros #30075

merged 2 commits into from
Nov 29, 2015

Conversation

kyeah
Copy link
Contributor

@kyeah kyeah commented Nov 26, 2015

Fixes #28424 (item macros), #30067 (impl item macros), and pattern macros.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sanxiyn
Copy link
Member

sanxiyn commented Nov 29, 2015

Shouldn't it be last_span.hi instead of span.hi?

@kyeah
Copy link
Contributor Author

kyeah commented Nov 29, 2015

Ah yep, just pushed a quick fix.

@sanxiyn
Copy link
Member

sanxiyn commented Nov 29, 2015

Failed tidy. (I know this can be annoying. I apologize.)

@sanxiyn
Copy link
Member

sanxiyn commented Nov 29, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 29, 2015

📌 Commit 920120e has been approved by sanxiyn

@bors
Copy link
Collaborator

bors commented Nov 29, 2015

⌛ Testing commit 920120e with merge 323781c...

bors added a commit that referenced this pull request Nov 29, 2015
Fixes #28424 (item macros), #30067 (impl item macros), and pattern macros.
@bors
Copy link
Collaborator

bors commented Nov 29, 2015

💔 Test failed - auto-mac-64-opt

@sanxiyn
Copy link
Member

sanxiyn commented Nov 29, 2015

@bors retry

@bors bors merged commit 920120e into rust-lang:master Nov 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants