-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Book on slices: Mention internal representation #30807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When I read the book, the following sentence of the reference documentation helped me greatly to understand slices: "Slices are a view into a block of memory represented as a pointer and a length." In this commit, I tried to integrate the gist of that into the slice section inside of "primitive-types.md".
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
📌 Commit 235bdf1 has been approved by |
@bors: p=0 |
@bors: rollup |
Whew, sorry, I have been doing too many rollups lately, I didn't meen to set a high priority! |
@steveklabnik No worries. Just a very minor suggestion anyways. But since I was rereading the book from start to end, I thought that I'd mention it. Very nice work, BTW, thank you! |
Thank you! :) |
When I read the book, the following sentence of the reference documentation helped me greatly to understand slices: "Slices are a view into a block of memory represented as a pointer and a length." In this commit, I tried to integrate the gist of that into the slice section inside of "primitive-types.md". I am not a native speaker, so feel very free to improve the wording. r? @steveklabnik
When I read the book, the following sentence of the reference documentation helped me greatly to understand slices:
"Slices are a view into a block of memory represented as a pointer and a length."
In this commit, I tried to integrate the gist of that into the slice section inside of "primitive-types.md". I am not a native speaker, so feel very free to improve the wording.
r? @steveklabnik