Skip to content

Book on slices: Mention internal representation #30807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2016
Merged

Conversation

kolloch
Copy link

@kolloch kolloch commented Jan 10, 2016

When I read the book, the following sentence of the reference documentation helped me greatly to understand slices:

"Slices are a view into a block of memory represented as a pointer and a length."

In this commit, I tried to integrate the gist of that into the slice section inside of "primitive-types.md". I am not a native speaker, so feel very free to improve the wording.

r? @steveklabnik

When I read the book, the following sentence of the reference documentation helped me greatly to understand slices:

"Slices are a view into a block of memory represented as a pointer and a length."

In this commit, I tried to integrate the gist of that into the slice section inside of "primitive-types.md".
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Hi @kolloch ! I'm sorry this PR slipped through the cracks somehow.

@bors: r+ p=1

@bors
Copy link
Collaborator

bors commented Jan 19, 2016

📌 Commit 235bdf1 has been approved by steveklabnik

@steveklabnik
Copy link
Member

@bors: p=0

@steveklabnik
Copy link
Member

@bors: rollup

@steveklabnik
Copy link
Member

Whew, sorry, I have been doing too many rollups lately, I didn't meen to set a high priority!

@kolloch
Copy link
Author

kolloch commented Jan 19, 2016

@steveklabnik No worries. Just a very minor suggestion anyways. But since I was rereading the book from start to end, I thought that I'd mention it. Very nice work, BTW, thank you!

@steveklabnik
Copy link
Member

Thank you! :)

bors added a commit that referenced this pull request Jan 23, 2016
When I read the book, the following sentence of the reference documentation helped me greatly to understand slices:

"Slices are a view into a block of memory represented as a pointer and a length."

In this commit, I tried to integrate the gist of that into the slice section inside of "primitive-types.md". I am not a native speaker, so feel very free to improve the wording.

r? @steveklabnik
@bors
Copy link
Collaborator

bors commented Jan 23, 2016

⌛ Testing commit 235bdf1 with merge 228afd7...

@bors bors merged commit 235bdf1 into rust-lang:master Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants