Added Self where possible in LinkedList (updated)

[cmlsharp]

Updated pull request

@gankro

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[Gankra]

This should have still been T, and is causing infinite recursion in type checking.

[cmlsharp]

Ahh, I meant to type Self::Item

[Gankra]

rustc: x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcollections
src/libcollections/linked_list.rs:899:1: 906:2 error: type mismatch resolving `<linked_list::Iter<'_, &T> as core::iter::Iterator>::Item == &T`:
 expected &-ptr,
    found type parameter [E0271]
src/libcollections/linked_list.rs:899 impl<'a, T> IntoIterator for &'a LinkedList<T> {
src/libcollections/linked_list.rs:900     type Item = &'a T;
src/libcollections/linked_list.rs:901     type IntoIter = Iter<'a, Self::Item>;
src/libcollections/linked_list.rs:902 
src/libcollections/linked_list.rs:903     fn into_iter(self) -> Self::IntoIter {
src/libcollections/linked_list.rs:904         self.iter()
                                      ...
src/libcollections/linked_list.rs:899:1: 906:2 help: run `rustc --explain E0271` to see a detailed explanation
src/libcollections/linked_list.rs:899:1: 906:2 note: required by `core::iter::IntoIterator`
error: aborting due to previous error
make: *** [x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/stamp.collections] Error 101

[Gankra]

Iter<'a, T>, not Iter<'a, &T>

[brson]

r? @gankro

[bluss]

Thanks, this looks good. Can you please squash together all the commits?

A reviewer can r=me when the squash is done.

[bluss]

Like oli-obk said, there's no notification for new commits or pushes, so a message in the PR thread is good way to notify those subscribed to the PR.

[cyplo]

Hello ! Is this one still relevant ? If so - is there anything blocking it from getting merged ? thanks !

[mrhota]

@crossroads1112 if you're short on time, I can re-open this into another PR and squash these commits for you. Let me know.

[bluss]

Thanks so much @crossroads1112, I will close this PR for inactivity, but you (or anyone else) are welcome to submit this change again.