Use raw pointers to avoid aliasing in str::split_at_mut #31052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
bors
added a commit
that referenced
this pull request
Jan 21, 2016
Use raw pointers to avoid aliasing in str::split_at_mut Introduce private functions from_raw_parts, from_raw_parts_mut for str to factor out the logic. We want to use raw pointers here instead of duplicating a &mut str, to be on safer ground w.r.t rust aliasing rules. This has already been fixed for slices in PR #27358, issue #27357
|
💔 Test failed - auto-win-msvc-64-opt |
|
Oh wow, an interesting build failure. I have to suspect that the |
Introduce private function from_raw_parts_mut for str to factor out the logic. We want to use raw pointers here instead of duplicating a &mut str, to be on safer ground w.r.t rust aliasing rules.
bluss
force-pushed
the
split-at-mut-str
branch
from
8d71ca5 to
ba9a3bc
Compare
|
PR revision: I removed the changes to slice_unchecked, slice_unchecked_mut. |
| /// str is returned. | ||
| /// | ||
| unsafe fn from_raw_parts_mut<'a>(p: *mut u8, len: usize) -> &'a mut str { | ||
| mem::transmute::<&mut [u8], &mut str>(slice::from_raw_parts_mut(p, len)) |
There was a problem hiding this comment.
transmute -> from_utf8_unchecked?
There was a problem hiding this comment.
Needs a _mut version. I could add that.
There was a problem hiding this comment.
Should I? Always quicker to avoid having to champion new public API for example.
There was a problem hiding this comment.
I would personally prefer to stabilize from_utf8_unchecked_mut than from_raw_parts_mut, but I don't think we necessarily need the function just yet so I would be fine just leaving this as -is.
There was a problem hiding this comment.
That is a good plan for the future.
|
The commit how it looked when causing the interesting error https://gist.github.com/bluss/0f0f90c0b5b7ec5789d4 Edit: Wrong version. fixed. |
bors
added a commit
that referenced
this pull request
Jan 21, 2016
Use raw pointers to avoid aliasing in str::split_at_mut Introduce private function from_raw_parts_mut for str to factor out the logic. We want to use raw pointers here instead of duplicating a &mut str, to be on safer ground w.r.t rust aliasing rules. This has already been fixed for slices in PR #27358, issue #27357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use raw pointers to avoid aliasing in str::split_at_mut
Introduce private function from_raw_parts_mut for str to factor out the logic.
We want to use raw pointers here instead of duplicating a &mut str, to
be on safer ground w.r.t rust aliasing rules.
This has already been fixed for slices in PR #27358, issue #27357