Skip to content

Clarify when Cargo.lock is created by cargo build in the book #31159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2016

Conversation

dirk
Copy link
Contributor

@dirk dirk commented Jan 24, 2016

Also remove a "finally" in the section about building for release to make it feel a bit friendlier.

Also remove a "finally" in the section about building for release
to make it feel a bit friendlier.
@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@dirk
Copy link
Contributor Author

dirk commented Jan 24, 2016

This should close #31149 if/when it's merged.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Thank you!

This should close #31149 if/when it's merged.

For future reference: github will do this automatically if you include Closes #31159 or Fixes #31149 in your commit message.

@bors
Copy link
Collaborator

bors commented Jan 24, 2016

📌 Commit a469cef has been approved by steveklabnik

@dirk
Copy link
Contributor Author

dirk commented Jan 24, 2016

D'oh. Forgot to include the "Closes #X" syntax in the message last night. Thanks for the reminder! 😛

On Jan 24, 2016, at 11:09 AM, Steve Klabnik [email protected] wrote:

@bors: r+ rollup

Thank you!

This should close #31149 if/when it's merged.

For future reference: github will do this automatically if you include Closes #31159 or Fixes #31149 in your commit message.


Reply to this email directly or view it on GitHub.

@bors
Copy link
Collaborator

bors commented Jan 24, 2016

⌛ Testing commit a469cef with merge 9bc2573...

@bors
Copy link
Collaborator

bors commented Jan 24, 2016

💔 Test failed - auto-mac-32-opt

@steveklabnik
Copy link
Member

@bors: retry

bors added a commit that referenced this pull request Jan 25, 2016
Also remove a "finally" in the section about building for release to make it feel a bit friendlier.
@bors
Copy link
Collaborator

bors commented Jan 25, 2016

⌛ Testing commit a469cef with merge 6866f13...

@bors bors merged commit a469cef into rust-lang:master Jan 25, 2016
@dirk dirk deleted the dirk/clarify-cargo-lock branch January 25, 2016 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants