Skip to content

Fix pretty_printer to print omitted type _ marker #31160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2016

Conversation

nxnfufunezn
Copy link
Contributor

Fixes #31073
r? @eddyb

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -1935,7 +1935,7 @@ impl<'a> State<'a> {

pub fn print_fn_args(&mut self,
decl: &hir::FnDecl,
opt_explicit_self: Option<&hir::ExplicitSelf_>)
opt_explicit_self: Option<&hir::ExplicitSelf_>, is_closure: bool)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a new line separating the two arguments here

@nxnfufunezn
Copy link
Contributor Author

@pnkfelix done

@eddyb
Copy link
Member

eddyb commented Jan 24, 2016

This also needs a test (see src/test/pretty - tests with both .rs and .pp, specifically).

@eddyb
Copy link
Member

eddyb commented Jan 25, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 25, 2016

📌 Commit 014fc02 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jan 26, 2016

⌛ Testing commit 014fc02 with merge 1972c50...

bors added a commit that referenced this pull request Jan 26, 2016
@bors bors merged commit 014fc02 into rust-lang:master Jan 26, 2016
@nxnfufunezn nxnfufunezn deleted the ppwild-31073 branch January 28, 2016 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants