Add section about memory safety to ffi::CString documentation
#31171
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| /// | ||
| /// # Safety | ||
| /// | ||
| /// CStrings are intended for working with traditional C-style strings |
There was a problem hiding this comment.
Could you put CString is graves, both here and below?
There was a problem hiding this comment.
@steveklabnik: Fixed in 71b526b!
Also a minor language tweak to the documentation of the `ffi::CString::from_raw` function.
dirk
force-pushed
the
dirk/safety-section-in-cstring-docs
branch
from
7fddeec to
71b526b
Compare
|
@steveklabnik: Updated docs to have |
| /// `into_raw`. The length of the string will be recalculated | ||
| /// using the pointer. | ||
| /// This should only ever be called with a pointer that was earlier | ||
| /// obtained by calling `into_raw` on a CString. Additionally, the length |
There was a problem hiding this comment.
one last CString here, then we're good to go :)
There was a problem hiding this comment.
Oh jeez, I'm hopeless. 😞
|
@steveklabnik: Those last two backtick formatting nits are fixed in 9cfa191. |
|
@bors: r+ rollup Thanks! And no, you're not: I mess these things up all the time :) |
|
📌 Commit 9cfa191 has been approved by |
|
⌛ Testing commit 9cfa191 with merge 11e3113... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: retry On Wed, Jan 27, 2016 at 11:06 PM, bors [email protected] wrote:
|
…eveklabnik Also a minor language tweak to the documentation of the `ffi::CString::from_raw` function.
Also a minor language tweak to the documentation of the
ffi::CString::from_rawfunction.