Fix #31502 #31557
Merged
Fix #31502 #31557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you edit the commit message to explain what's going on as well? It helps to have some more context than just "Fix #XXXX" Otherwise looks good to me, though, thanks! |
retep998
force-pushed
the
house-directory
branch
from
b84b342 to
dc97023
Compare
Signed-off-by: Peter Atashian <[email protected]>
|
Renamed commit message. |
|
Can you extend the unit test to make sure the new version indeed fixes the bug? How about calling |
|
The unit test won't actually test that branch since it requires |
bors
added a commit
that referenced
this pull request
Feb 13, 2016
This is the simple solution. I know @nodakai was working on a more complex solution that overhauled the `fill_utf16_buf` stuff. r? @alexcrichton
|
Oh, I didn't notice we had a run-pass test specifically for that. I guess it could benefit from a more aggressive check. That said, since this PR already landed I'm rather unmotivated to adjust that test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simple solution. I know @nodakai was working on a more complex solution that overhauled the
fill_utf16_bufstuff.r? @alexcrichton