rustdoc: Fix search-index entry for inherent-associated-const #31596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normal constants have their own page while associated constants are embedded within their parent-items page.
Search results use the mapping found in `ItemType::to_static_str` for the identifier, which could not be found on the page in the case of associated items.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I've noticed that associated types, unlike associated consts, in impls are not recorded in the search-index because of noisy search results. Right now inherent-associated-types don't work yet but I would imagine that whatever solution is applied to them should be used for inherent-associated-constants too. edit: (there is currently no distinction between an implemented associated-item from a trait and an inherent-associated-item) |
|
⌛ Testing commit 938202c with merge c438802... |
bors
added a commit
that referenced
this pull request
Feb 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.