Harmonize fpu options on armv7 Linux #31814
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -21,6 +21,6 @@ CFG_UNIXY_armv7-unknown-linux-gnueabihf := 1 | |||
| CFG_LDPATH_armv7-unknown-linux-gnueabihf := | |||
| CFG_RUN_armv7-unknown-linux-gnueabihf=$(2) | |||
| CFG_RUN_TARG_armv7-unknown-linux-gnueabihf=$(call CFG_RUN_armv7-unknown-linux-gnueabihf,,$(2)) | |||
| RUSTC_FLAGS_armv7-unknown-linux-gnueabihf := -C target-feature=+v7,+vfp2,+neon | |||
| RUSTC_FLAGS_armv7-unknown-linux-gnueabihf := -C target-feature=+v7,+vfp3,+neon | |||
There was a problem hiding this comment.
This can actually be removed as they're part of the features below as well, would you mind just going ahead and clearing out this line?
|
Ah, right - the target's pretty specialised already. |
|
The only difference it could probably make is Wait, I keep forgetting it's a separate target nowadays. Ok, it's done. |
|
⌛ Testing commit 8ddd86a with merge 603e370... |
|
💔 Test failed - auto-win-msvc-64-opt |
|
@bors: retry On Mon, Feb 22, 2016 at 6:28 PM, bors [email protected] wrote:
|
The `vfp2` option was a leftover from `armv6` compatibility features of the original armhf target. Gcc defaults to `vfp3`on `armv7` hard-float linux systems so we should make it the default for rustc too.
|
⌛ Testing commit 8ddd86a with merge be7196a... |
The
vfp2option was a leftover fromarmv6compatibility features of the original armhf target.Gcc defaults to
vfp3onarmv7hard-float linux systems so we should make it the default for rustc too.