std: Link to gcc_s on NetBSD #32407
Merged
std: Link to gcc_s on NetBSD #32407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the nightlies we're producing fail when linking some C code into a
Rust application with the error message:
libgcc_s.so.1: error adding symbols: DSO missing from command line
By linking `gcc_s` instead of `gcc` this error goes away. I haven't tested this
on NetBSD itself, but should help get the Linux cross-compile image moreso up
and working!
|
r? @brson |
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this pull request
Mar 22, 2016
This commit beefs up Cargo's makefiles to support nightly builds of Cargo for multiple platforms. This primarily involves vendoring the logic of how to build OpenSSL for statically linking against Cargo into the Makefiles directly. We'll have to update the version of OpenSSL as releases are made, but we essentially already do that with the normal docker container. The Linux nightlies will still run in the normal dist docker container (a really old CentOS build) and builds for new platforms will happen in the standard linux-cross container we use for other cross builds. The nightly versions of these will produce Cargo tarballs for a whole bunch of platforms to get uploaded. This has been tested in the `alexcrichton/rust-slave-linux-cross:2016-03-17b` docker container for the 3 ARM targets and FreeBSD target. NetBSD will come once rust-lang/rust#32407 lands.
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Mar 23, 2016
Prepare for ARM/FreeBSD/NetBSD nightlies This commit beefs up Cargo's makefiles to support nightly builds of Cargo for multiple platforms. This primarily involves vendoring the logic of how to build OpenSSL for statically linking against Cargo into the Makefiles directly. We'll have to update the version of OpenSSL as releases are made, but we essentially already do that with the normal docker container. The Linux nightlies will still run in the normal dist docker container (a really old CentOS build) and builds for new platforms will happen in the standard linux-cross container we use for other cross builds. The nightly versions of these will produce Cargo tarballs for a whole bunch of platforms to get uploaded. This has been tested in the `alexcrichton/rust-slave-linux-cross:2016-03-17b` docker container for the 3 ARM targets and FreeBSD target. NetBSD will come once rust-lang/rust#32407 lands.
|
@bors: r+ |
|
📌 Commit f34c0e6 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 25, 2016
std: Link to gcc_s on NetBSD
Currently the nightlies we're producing fail when linking some C code into a
Rust application with the error message:
libgcc_s.so.1: error adding symbols: DSO missing from command line
By linking `gcc_s` instead of `gcc` this error goes away. I haven't tested this
on NetBSD itself, but should help get the Linux cross-compile image moreso up
and working!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the nightlies we're producing fail when linking some C code into a
Rust application with the error message:
By linking
gcc_sinstead ofgccthis error goes away. I haven't tested thison NetBSD itself, but should help get the Linux cross-compile image moreso up
and working!