-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Reword explanation of 'size' types. #32906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -97,9 +97,11 @@ and `i64` is a signed, 64-bit integer. | |
|
||
## Variable sized types | ||
|
||
Rust also provides types whose size depends on the size of a pointer of the | ||
underlying machine. These types have ‘size’ as the category, and come in signed | ||
and unsigned varieties. This makes for two types: `isize` and `usize`. | ||
Rust also provides types whose particular size depends on the underlying machine | ||
architecture. Their range is sufficient to express sizes of collections and they | ||
are used to address items in a vector, for example. These types have ‘size’ as | ||
the category, and come in signed and unsigned varieties. This makes for two types: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "This makes for two types". I don't really understand this part. Rewording needed? |
||
`isize` and `usize`. | ||
|
||
## Floating-point types | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the "for example" part misplaced or too much.