Bare raw pointers have been disallowed forever #32915
Conversation
This change was in 0.12.0, a year and a half ago. Let's move on!
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| likely use `*mut T`, but otherwise `*T` is now \ | ||
| known as `*const T`"); | ||
| "bare raw pointers are not allowed, use `*mut T` or \ | ||
| `*const T` as appropriate"); |
There was a problem hiding this comment.
Great sentiment. Can we change the wording even more? It doesn't make sense to say "bare raw pointer" when that doesn't exist as a concept (?). Technically, it's just "expected mut or const in raw pointer type (use *mut T or *const T as appropriate)", something like that.
There was a problem hiding this comment.
I like your wording. I have updated the message.
"Bare raw pointer" does not exist as a concept.
|
@bors: r+ |
|
📌 Commit 222f47a has been approved by |
Bare raw pointers have been disallowed forever This change was in 0.12.0, a year and a half ago. Let's move on!
dtolnay
added
A-parser
This change was in 0.12.0, a year and a half ago. Let's move on!