Skip to content

add more comprehensive tests for incr. comp. #33851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions src/test/incremental/struct_add_field.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test incremental compilation tracking where we change field names
// in between revisions (hashing should be stable).

// revisions:rpass1 rpass2

#![feature(rustc_attrs)]

pub struct X {
pub x: u32,

#[cfg(rpass2)]
pub x2: u32,
}

pub struct EmbedX {
x: X
}

pub struct Y {
pub y: char
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")]
pub fn use_X(x: X) -> u32 {
x.x as u32
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")]
pub fn use_EmbedX(embed: EmbedX) -> u32 {
embed.x.x as u32
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")] // FIXME(#33850) should be clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting...

pub fn use_Y() {
let x: Y = Y { y: 'c' };
}

pub fn main() { }
55 changes: 55 additions & 0 deletions src/test/incremental/struct_change_field_name.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test incremental compilation tracking where we change field names
// in between revisions (hashing should be stable).

// revisions:rpass1 cfail2

#![feature(rustc_attrs)]

#[cfg(rpass1)]
pub struct X {
pub x: u32
}

#[cfg(cfail2)]
pub struct X {
pub y: u32
}

pub struct EmbedX {
x: X
}

pub struct Y {
pub y: char
}

#[rustc_dirty(label="TypeckItemBody", cfg="cfail2")]
pub fn use_X() -> u32 {
let x: X = X { x: 22 };
//[cfail2]~^ ERROR structure `X` has no field named `x`
x.x as u32
//[cfail2]~^ ERROR attempted access of field `x`
}

#[rustc_dirty(label="TypeckItemBody", cfg="cfail2")]
pub fn use_EmbedX(embed: EmbedX) -> u32 {
embed.x.x as u32
//[cfail2]~^ ERROR attempted access of field `x`
}

#[rustc_dirty(label="TypeckItemBody", cfg="cfail2")] // FIXME(#33850) should be clean
pub fn use_Y() {
let x: Y = Y { y: 'c' };
}

pub fn main() { }
53 changes: 53 additions & 0 deletions src/test/incremental/struct_change_field_type.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test incremental compilation tracking where we change nothing
// in between revisions (hashing should be stable).

// revisions:rpass1 rpass2

#![feature(rustc_attrs)]

#[cfg(rpass1)]
pub struct X {
pub x: u32
}

#[cfg(rpass2)]
pub struct X {
pub x: i32
}

pub struct EmbedX {
x: X
}

pub struct Y {
pub y: char
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")]
pub fn use_X() -> u32 {
let x: X = X { x: 22 };
x.x as u32
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")]
pub fn use_EmbedX(x: EmbedX) -> u32 {
let x: X = X { x: 22 };
x.x as u32
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")] // FIXME(#33850) should be clean
pub fn use_Y() {
let x: Y = Y { y: 'c' };
}

pub fn main() { }
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![crate_type="rlib"]

#[cfg(rpass1)]
pub struct X {
pub x: u32
}

#[cfg(rpass2)]
pub struct X {
pub x: i32
}

pub struct EmbedX {
pub x: X
}

pub struct Y {
pub y: char
}
36 changes: 36 additions & 0 deletions src/test/incremental/struct_change_field_type_cross_crate/b.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// aux-build:a.rs
// revisions:rpass1 rpass2

#![feature(rustc_attrs)]

extern crate a;

use a::*;

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")]
pub fn use_X() -> u32 {
let x: X = X { x: 22 };
x.x as u32
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")]
pub fn use_EmbedX(embed: EmbedX) -> u32 {
embed.x.x as u32
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")] // FIXME(#33850) should be clean
pub fn use_Y() {
let x: Y = Y { y: 'c' };
}

pub fn main() { }
53 changes: 53 additions & 0 deletions src/test/incremental/struct_change_nothing.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test incremental compilation tracking where we change nothing
// in between revisions (hashing should be stable).

// revisions:rpass1 rpass2

#![feature(rustc_attrs)]

#[cfg(rpass1)]
pub struct X {
pub x: u32
}

#[cfg(rpass2)]
pub struct X {
pub x: u32
}

pub struct EmbedX {
x: X
}

pub struct Y {
pub y: char
}

#[rustc_clean(label="TypeckItemBody", cfg="rpass2")]
pub fn use_X() -> u32 {
let x: X = X { x: 22 };
x.x as u32
}

#[rustc_clean(label="TypeckItemBody", cfg="rpass2")]
pub fn use_EmbedX(x: EmbedX) -> u32 {
let x: X = X { x: 22 };
x.x as u32
}

#[rustc_clean(label="TypeckItemBody", cfg="rpass2")]
pub fn use_Y() {
let x: Y = Y { y: 'c' };
}

pub fn main() { }
52 changes: 52 additions & 0 deletions src/test/incremental/struct_remove_field.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test incremental compilation tracking where we change field names
// in between revisions (hashing should be stable).

// revisions:rpass1 rpass2

#![feature(rustc_attrs)]

#[cfg(rpass1)]
pub struct X {
pub x: u32,
pub x2: u32,
}

#[cfg(rpass2)]
pub struct X {
pub x: u32,
}

pub struct EmbedX {
x: X
}

pub struct Y {
pub y: char
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")]
pub fn use_X(x: X) -> u32 {
x.x as u32
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")]
pub fn use_EmbedX(embed: EmbedX) -> u32 {
embed.x.x as u32
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")] // FIXME(#33850) should be clean
pub fn use_Y() {
let x: Y = Y { y: 'c' };
}

pub fn main() { }
4 changes: 4 additions & 0 deletions src/test/incremental/type_alias_cross_crate/auxiliary/a.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ pub type X = u32;
#[cfg(rpass2)]
pub type X = i32;

// this version doesn't actually change anything:
#[cfg(rpass3)]
pub type X = i32;

pub type Y = char;

pub fn foo() { }
4 changes: 3 additions & 1 deletion src/test/incremental/type_alias_cross_crate/b.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,21 @@
// except according to those terms.

// aux-build:a.rs
// revisions:rpass1 rpass2
// revisions:rpass1 rpass2 rpass3

#![feature(rustc_attrs)]

extern crate a;

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")]
#[rustc_clean(label="TypeckItemBody", cfg="rpass3")]
pub fn use_X() -> u32 {
let x: a::X = 22;
x as u32
}

#[rustc_clean(label="TypeckItemBody", cfg="rpass2")]
#[rustc_clean(label="TypeckItemBody", cfg="rpass3")]
pub fn use_Y() {
let x: a::Y = 'c';
}
Expand Down