-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Retry on EINTR in Bytes and Chars. #33974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry on EINTR in Bytes and Chars. #33974
Conversation
habnabit
commented
May 31, 2016
Since Bytes and Chars called directly into Read::read, they didn't use any of the retrying wrappers. This allows both iterator types to retry.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
📌 Commit e7d423a has been approved by |
⌛ Testing commit e7d423a with merge c2cc8fd... |
💔 Test failed - auto-linux-64-opt |
@bors: retry
On Mon, Jul 18, 2016 at 11:54 PM, bors [email protected] wrote:
|
…xcrichton Retry on EINTR in Bytes and Chars. >Since Bytes and Chars called directly into Read::read, they didn't use any of the retrying wrappers. This allows both iterator types to retry.