Skip to content

Retry on EINTR in Bytes and Chars. #33974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

habnabit
Copy link
Contributor

Since Bytes and Chars called directly into Read::read, they didn't use any of the retrying wrappers. This allows both iterator types to retry.

Since Bytes and Chars called directly into Read::read, they didn't use
any of the retrying wrappers. This allows both iterator types to retry.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

cc #33801 and #27802, this is pretty related to both of those as well

@sfackler sfackler added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 20, 2016
@alexcrichton
Copy link
Member

Discussed during libs triage today the decision was to merge, sorry for the delay @habnabit but thanks for the PR!

@bors: r+

@bors
Copy link
Collaborator

bors commented Jul 19, 2016

📌 Commit e7d423a has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jul 19, 2016

⌛ Testing commit e7d423a with merge c2cc8fd...

@bors
Copy link
Collaborator

bors commented Jul 19, 2016

💔 Test failed - auto-linux-64-opt

@alexcrichton
Copy link
Member

@bors: retry

  • Weird buildbot timeout?

On Mon, Jul 18, 2016 at 11:54 PM, bors [email protected] wrote:

💔 Test failed - auto-linux-64-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/9802


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#33974 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95G_4EkB_PlrCtNu9uvtIlIf3dxIhks5qXHSRgaJpZM4IqH-b
.

@bors
Copy link
Collaborator

bors commented Jul 19, 2016

⌛ Testing commit e7d423a with merge 92400cf...

bors added a commit that referenced this pull request Jul 19, 2016
…xcrichton

Retry on EINTR in Bytes and Chars.

>Since Bytes and Chars called directly into Read::read, they didn't use any of the retrying wrappers. This allows both iterator types to retry.
@bors bors merged commit e7d423a into rust-lang:master Jul 19, 2016
@bors bors mentioned this pull request Jul 19, 2016
@habnabit habnabit deleted the eintr-retry-for-read-iterators branch August 21, 2016 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants