Skip to content

Fix a few links in the book #34021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Jun 1, 2016

Links to directories and direct links to doc.rust-lang.org don't work properly
when viewing the docs offline so fix them.

r? @steveklabnik

Links to directories and direct links to doc.rust-lang.org don't work properly
when viewing the docs offline so fix them.
@steveklabnik
Copy link
Member

Ah, nice catch.

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 1, 2016

📌 Commit 658253d has been approved by steveklabnik

@alexcrichton
Copy link
Member

May be worth also updating the link checker script with this logic?

On Wednesday, June 1, 2016, bors [email protected] wrote:

📌 Commit 658253d
658253d
has been approved by steveklabnik


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34021 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95NKjNFeRMRB5qHkvzqXFboESEYjQks5qHbuJgaJpZM4Irws3
.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 2, 2016
…klabnik

Fix a few links in the book

Links to directories and direct links to doc.rust-lang.org don't work properly
when viewing the docs offline so fix them.

r? @steveklabnik
bors added a commit that referenced this pull request Jun 2, 2016
Rollup of 7 pull requests

- Successful merges: #33993, #34013, #34014, #34015, #34019, #34021, #34033
- Failed merges:
@ollie27
Copy link
Member Author

ollie27 commented Jun 2, 2016

yeah, I've modified linkchecker to treat directory links as errors in #34039.

@bors bors merged commit 658253d into rust-lang:master Jun 2, 2016
bors added a commit that referenced this pull request Jun 5, 2016
linkchecker: Treat directory links as errors

Directory links don't work well offline so they should be treated as errors.

All examples of this I know of are fixed in #34021.
@ollie27 ollie27 deleted the book_links_offline branch June 7, 2016 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants