trans: don't misuse C_nil for ZSTs other than (). #34167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 |
|
📌 Commit 22fa769 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 8, 2016
trans: don't misuse C_nil for ZSTs other than (). `C_nil` is actually `C_null` for `()` so `TempRef::new_operand` was treating all ZSTs as `()`. This should allow running Servo with `RUSTFLAGS=-Zorbit`, assuming there are no other bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C_nilis actuallyC_nullfor()soTempRef::new_operandwas treating all ZSTs as().This should allow running Servo with
RUSTFLAGS=-Zorbit, assuming there are no other bugs.