Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}` #34456

tbu- · 2016-06-24T18:55:30Z

No description provided.

rust-highfive · 2016-06-24T18:55:34Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

aturon · 2016-06-27T20:27:28Z

Thanks!

@bors: r+

apasel422 · 2016-07-07T12:00:28Z

@bors r=aturon

bors · 2016-07-07T12:00:29Z

📌 Commit ceb4e3c has been approved by aturon

bors · 2016-07-07T12:34:36Z

⌛ Testing commit ceb4e3c with merge dc0a71b...

bors · 2016-07-07T12:46:56Z

💔 Test failed - auto-mac-cross-ios-opt

apasel422 · 2016-07-07T12:49:08Z

src/libstd/sys/unix/time.rs

@@ -169,7 +169,7 @@ mod inner {
                tv_usec: 0,
            };
            cvt(unsafe {
-                libc::gettimeofday(&mut s, 0 as *mut _)
+                libc::gettimeofday(&mut s, ptr::null_mut())


Seems that this file is missing an import of ptr.

Should be fixed.

apasel422 · 2016-07-07T13:53:45Z

Travis output:

src/libstd/sys/unix/time.rs:13:5: 13:8 error: unused import
src/libstd/sys/unix/time.rs:13 use ptr;
                                   ^~~
src/libstd/lib.rs:289:31: 289:39 note: lint level defined here
src/libstd/lib.rs:289 #![cfg_attr(not(stage0), deny(warnings))]

apasel422 · 2016-07-07T14:54:49Z

Travis output:

src/libtest/lib.rs:71:5: 71:13 error: unused import
src/libtest/lib.rs:71 use std::ptr;
                          ^~~~~~~~
src/libtest/lib.rs:34:31: 34:39 note: lint level defined here
src/libtest/lib.rs:34 #![cfg_attr(not(stage0), deny(warnings))]

tbu- · 2016-07-07T16:30:45Z

Travis successfully compiled the code, so it should be good now.

apasel422 · 2016-07-07T16:33:37Z

@bors: r=aturon

bors · 2016-07-07T16:33:38Z

📌 Commit 8fd087a has been approved by aturon

eddyb · 2016-07-07T18:03:31Z

@bors rollup

Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}`

Rollup of 9 pull requests - Successful merges: #34097, #34456, #34610, #34612, #34659, #34688, #34691, #34699, #34700 - Failed merges:

Manishearth · 2016-07-08T09:27:12Z

https://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/4820

tbu- · 2016-07-08T10:02:55Z

Fixed.

Rollup of 9 pull requests - Successful merges: #34097, #34456, #34610, #34612, #34659, #34688, #34691, #34699, #34700 - Failed merges:

bors · 2016-07-08T22:02:43Z

☔ The latest upstream changes (presumably #33890) made this pull request unmergeable. Please resolve the merge conflicts.

tbu- · 2016-07-12T08:41:29Z

Rebased.

eddyb · 2016-07-12T10:56:44Z

@bors r=aturon

bors · 2016-07-12T10:56:45Z

📌 Commit 81e95c1 has been approved by aturon

Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}`

Rollup of 7 pull requests - Successful merges: #34456, #34733, #34777, #34794, #34799, #34804, #34818 - Failed merges: #33951

rust-highfive assigned aturon Jun 24, 2016

Stebalien mentioned this pull request Jun 27, 2016

Suggest ptr::null, ptr::null_mut over casting. rust-lang/rust-clippy#1047

Closed

apasel422 reviewed Jul 7, 2016
View reviewed changes

tbu- force-pushed the pr_ptr_null branch from ceb4e3c to cb16aa8 Compare July 7, 2016 13:28

tbu- force-pushed the pr_ptr_null branch from cb16aa8 to 02915a6 Compare July 7, 2016 14:03

tbu- force-pushed the pr_ptr_null branch from 02915a6 to 8fd087a Compare July 7, 2016 14:58

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 8, 2016

Rollup merge of rust-lang#34456 - tbu-:pr_ptr_null, r=aturon

e74a472

Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}`

Manishearth mentioned this pull request Jul 8, 2016

Rollup of 9 pull requests #34720

Merged

bors added a commit that referenced this pull request Jul 8, 2016

Auto merge of #34720 - Manishearth:rollup, r=Manishearth

d8a65cd

Rollup of 9 pull requests - Successful merges: #34097, #34456, #34610, #34612, #34659, #34688, #34691, #34699, #34700 - Failed merges:

tbu- force-pushed the pr_ptr_null branch from 8fd087a to f8dfc57 Compare July 8, 2016 10:02

bors added a commit that referenced this pull request Jul 8, 2016

Auto merge of #34720 - Manishearth:rollup, r=Manishearth

e7751e4

Rollup of 9 pull requests - Successful merges: #34097, #34456, #34610, #34612, #34659, #34688, #34691, #34699, #34700 - Failed merges:

Use ptr::{null, null_mut} instead of 0 as *{const, mut}

81e95c1

tbu- force-pushed the pr_ptr_null branch from f8dfc57 to 81e95c1 Compare July 12, 2016 08:40

GuillaumeGomez mentioned this pull request Jul 14, 2016

Rollup of 7 pull requests #34819

Merged

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 15, 2016

Rollup merge of rust-lang#34456 - tbu-:pr_ptr_null, r=aturon

6f07b6c

Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}`

bors added a commit that referenced this pull request Jul 15, 2016

Auto merge of #34819 - GuillaumeGomez:rollup, r=GuillaumeGomez

3cc3ad1

Rollup of 7 pull requests - Successful merges: #34456, #34733, #34777, #34794, #34799, #34804, #34818 - Failed merges: #33951

bors merged commit 81e95c1 into rust-lang:master Jul 15, 2016

taiki-e mentioned this pull request Jul 20, 2019

chore: use ptr::{null, null_mut} instead of 0 as *{const, mut} tokio-rs/tokio#1333

Merged

taiki-e mentioned this pull request Aug 30, 2019

Use ptr::null_mut instead of 0 as *mut seanmonstar/num_cpus#84

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}` #34456

Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}` #34456

tbu- commented Jun 24, 2016

rust-highfive commented Jun 24, 2016

aturon commented Jun 27, 2016

apasel422 commented Jul 7, 2016

bors commented Jul 7, 2016

bors commented Jul 7, 2016

bors commented Jul 7, 2016

apasel422 Jul 7, 2016

tbu- Jul 7, 2016

apasel422 commented Jul 7, 2016

apasel422 commented Jul 7, 2016

tbu- commented Jul 7, 2016

apasel422 commented Jul 7, 2016

bors commented Jul 7, 2016

eddyb commented Jul 7, 2016

Manishearth commented Jul 8, 2016

tbu- commented Jul 8, 2016

bors commented Jul 8, 2016

tbu- commented Jul 12, 2016

eddyb commented Jul 12, 2016

bors commented Jul 12, 2016

Use ptr::{null, null_mut} instead of 0 as *{const, mut} #34456

Use ptr::{null, null_mut} instead of 0 as *{const, mut} #34456

Conversation

tbu- commented Jun 24, 2016

rust-highfive commented Jun 24, 2016

aturon commented Jun 27, 2016

apasel422 commented Jul 7, 2016

bors commented Jul 7, 2016

bors commented Jul 7, 2016

bors commented Jul 7, 2016

apasel422 Jul 7, 2016

Choose a reason for hiding this comment

tbu- Jul 7, 2016

Choose a reason for hiding this comment

apasel422 commented Jul 7, 2016

apasel422 commented Jul 7, 2016

tbu- commented Jul 7, 2016

apasel422 commented Jul 7, 2016

bors commented Jul 7, 2016

eddyb commented Jul 7, 2016

Manishearth commented Jul 8, 2016

tbu- commented Jul 8, 2016

bors commented Jul 8, 2016

tbu- commented Jul 12, 2016

eddyb commented Jul 12, 2016

bors commented Jul 12, 2016

Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}` #34456

Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}` #34456