Skip to content

evaluate the array length of fixed size array types in rustdoc #34684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 6, 2016

mitgates #34579

to fix it we'd need an expression simplifier.

r? @steveklabnik

cc @Osspial

@steveklabnik
Copy link
Member

This failed Travis, because it looks like some tests were testing that this behavior exists!

@oli-obk oli-obk force-pushed the eval_rustdoc_array_len branch 2 times, most recently from 31c6993 to 60c5dcf Compare July 11, 2016 15:02
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 12, 2016

travis likes it now

@alexcrichton
Copy link
Member

@bors: r+ 60c5dcfc4bf6edf600124f18156d582cbee98918

@bors
Copy link
Collaborator

bors commented Jul 12, 2016

⌛ Testing commit 60c5dcf with merge 2f5e1f3...

@bors
Copy link
Collaborator

bors commented Jul 12, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@oli-obk oli-obk force-pushed the eval_rustdoc_array_len branch from 60c5dcf to 9d33ce5 Compare July 13, 2016 08:36
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 13, 2016

fixed rustc/Cargo.lock

@alexcrichton
Copy link
Member

@bors: r+ 9d33ce5

@bors
Copy link
Collaborator

bors commented Jul 13, 2016

⌛ Testing commit 9d33ce5 with merge 3dbbe2f...

bors added a commit that referenced this pull request Jul 13, 2016
evaluate the array length of fixed size array types in rustdoc

mitgates #34579

to fix it we'd need an expression simplifier.

r? @steveklabnik

cc @Osspial
@bors bors merged commit 9d33ce5 into rust-lang:master Jul 14, 2016
@oli-obk oli-obk deleted the eval_rustdoc_array_len branch June 15, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants