evaluate the array length of fixed size array types in rustdoc #34684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
force-pushed
the
eval_rustdoc_array_len
branch
from
10aa8e9 to
dfc035c
Compare
|
This failed Travis, because it looks like some tests were testing that this behavior exists! |
oli-obk
force-pushed
the
eval_rustdoc_array_len
branch
2 times, most recently
from
31c6993 to
60c5dcf
Compare
|
travis likes it now |
|
@bors: r+ 60c5dcfc4bf6edf600124f18156d582cbee98918 |
|
⌛ Testing commit 60c5dcf with merge 2f5e1f3... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
oli-obk
force-pushed
the
eval_rustdoc_array_len
branch
from
60c5dcf to
9d33ce5
Compare
|
fixed |
bors
added a commit
that referenced
this pull request
Jul 13, 2016
evaluate the array length of fixed size array types in rustdoc mitgates #34579 to fix it we'd need an expression simplifier. r? @steveklabnik cc @Osspial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mitgates #34579
to fix it we'd need an expression simplifier.
r? @steveklabnik
cc @Osspial