Indicate where `std::slice` structs originate from. #34875

frewsxcv · 2016-07-17T01:42:54Z

No description provided.

ollie27 · 2016-07-17T12:45:43Z

src/libcore/slice.rs

@@ -915,6 +917,9 @@ macro_rules! make_mut_slice {
 ///     println!("{}", element);
 /// }
 /// ```
+///
+/// [`iter`]: ../primitive.slice.html#method.iter


These need to be like ../../std/primitive.slice.html#method.iter so the links work in the core docs as well.

You're right. I forgot the type doesn't also appear in the core docs.

frewsxcv · 2016-07-17T17:09:01Z

r? @GuillaumeGomez

GuillaumeGomez · 2016-07-18T09:08:37Z

Thanks!

@bors: r+ rollup

bors · 2016-07-18T09:08:39Z

📌 Commit b2f5b5a has been approved by GuillaumeGomez

…umeGomez Indicate where `std::slice` structs originate from. None

Rollup of 5 pull requests - Successful merges: #34807, #34853, #34875, #34884, #34889 - Failed merges:

frewsxcv force-pushed the std-slice-struct branch from 61957dc to 4e30293 Compare July 17, 2016 01:43

ollie27 reviewed Jul 17, 2016
View reviewed changes

Indicate where std::slice structs originate from.

b2f5b5a

frewsxcv force-pushed the std-slice-struct branch from 4e30293 to b2f5b5a Compare July 17, 2016 13:16

rust-highfive assigned GuillaumeGomez Jul 17, 2016

sanxiyn mentioned this pull request Jul 18, 2016

Rollup of 5 pull requests #34898

Merged

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Jul 18, 2016

Rollup merge of rust-lang#34875 - frewsxcv:std-slice-struct, r=Guilla…

b713849

…umeGomez Indicate where `std::slice` structs originate from. None

bors added a commit that referenced this pull request Jul 19, 2016

Auto merge of #34898 - sanxiyn:rollup, r=sanxiyn

27e766d

Rollup of 5 pull requests - Successful merges: #34807, #34853, #34875, #34884, #34889 - Failed merges:

bors merged commit b2f5b5a into rust-lang:master Jul 19, 2016

frewsxcv deleted the std-slice-struct branch October 2, 2016 23:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Indicate where `std::slice` structs originate from. #34875

Indicate where `std::slice` structs originate from. #34875

frewsxcv commented Jul 17, 2016

ollie27 Jul 17, 2016

frewsxcv Jul 17, 2016

frewsxcv commented Jul 17, 2016

GuillaumeGomez commented Jul 18, 2016

bors commented Jul 18, 2016

Indicate where std::slice structs originate from. #34875

Indicate where std::slice structs originate from. #34875

Conversation

frewsxcv commented Jul 17, 2016

ollie27 Jul 17, 2016

Choose a reason for hiding this comment

frewsxcv Jul 17, 2016

Choose a reason for hiding this comment

frewsxcv commented Jul 17, 2016

GuillaumeGomez commented Jul 18, 2016

bors commented Jul 18, 2016

Indicate where `std::slice` structs originate from. #34875

Indicate where `std::slice` structs originate from. #34875