Skip to content

Make configure not require ocamlc #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Make configure not require ocamlc #349

wants to merge 15 commits into from

Conversation

rillian
Copy link
Contributor

@rillian rillian commented May 4, 2011

Since moving to a downloadable snapshot for stage0, it's been
possible to complete the build without compiling code written
in ocaml. However, the configure script still required it to
be present.

This commit changes detection failure to a non-fatal condition,
allowing the build to complete on systems without an ocaml
compiler.

An info message is also made conditional.

rillian and others added 15 commits May 4, 2011 16:24
Since moving to a downloadable snapshot for stage0, it's been
possible to complete the build without compiling code written
in ocaml. However, the configure script still required it to
be present.

This commit changes detection failure to a non-fatal condition,
allowing the build to complete on systems without an ocaml
compiler.

An info message is also made conditional.
There was some confusion on whether the destructors took their
argument by pointer or direct value. They now take it directly, just
like other methods. You no longer get a segfault when a constructor
actually does something with its self value.
Since moving to a downloadable snapshot for stage0, it's been
possible to complete the build without compiling code written
in ocaml. However, the configure script still required it to
be present.

This commit changes detection failure to a non-fatal condition,
allowing the build to complete on systems without an ocaml
compiler.

An info message is also made conditional.
This applies c11675 by Julian Seward from valgrind trunk
(svn://svn.valgrind.org/valgrind/trunk) to rustrt's included
copies of memcheck.h and valgrind.h, effectively backporting
the fix from the unreleased 3.6.2. The commit simply applies
the gcc 'unused' attribute to the relevant declarations.

This change allows compilation of the runtime code under
gcc 4.6 with -Werror, as the makefile currently requests.
@graydon graydon closed this May 5, 2011
@graydon
Copy link
Contributor

graydon commented May 5, 2011

Cherry-picked. Thanks.

keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this pull request Dec 12, 2017
kazcw pushed a commit to kazcw/rust that referenced this pull request Oct 23, 2018
This way if the feature is statically detected then it'll be expanded to `true`

Closes rust-lang#349
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Oct 26, 2020
antoyo added a commit to antoyo/rust that referenced this pull request Oct 9, 2023
carolynzech pushed a commit to carolynzech/rust that referenced this pull request May 7, 2025
This is an automated PR to update Kani metrics.

The metrics have been updated by running `./scripts/run-kani.sh --run
metrics`.

Co-authored-by: github-merge-queue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants