new trait serialization, copyless bytes/str writer, and a str form_slice #3507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will need a snapshot before we can convert ebml and rustc to use the new-style serialization.
|
I got some things I want to merge in tomorrow, so I going to close this for now. |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Apr 25, 2024
avoid 'let _' in tests where we actually want the value to be computed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my version of a new trait-based serialization. It's a pretty straightforward port to traits. I named it serialization2 as we'll need to do the snapshot-dance in order to replace the old serialization. After we get this into a snapshot, I'll upgrade ebml, json, and the auto serializer to use it.
Also, this patch includes a new rewrite of the io bytes writer to cut down on the copies, and replacing the unwieldy
str::raw::from_buf_len_nocopywith astr::raw::form_slicethat matches the vec function.