Skip to content

Make version check in gdb_rust_pretty_printing.py more compatible. #35748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2016
Merged

Make version check in gdb_rust_pretty_printing.py more compatible. #35748

merged 1 commit into from
Aug 24, 2016
+1 −1

Conversation

michaelwoerister
Copy link
Member

Some versions of Python don't support the major field on the object returned by sys.version_info.

Fixes #35724

r? @brson

@michaelwoerister
Make version check in gdb_rust_pretty_printing.py more compatible.
6aca068 
Some versions of Python don't support the `major` field on the
object returned by `sys.version_info`.
@brson
Copy link
Contributor

brson commented Aug 23, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 23, 2016

📌 Commit 6aca068 has been approved by brson

@bors
Copy link
Collaborator

bors commented Aug 23, 2016

⌛ Testing commit 6aca068 with merge cca2eab...

@bors
Copy link
Collaborator

bors commented Aug 23, 2016

💔 Test failed - auto-linux-cross-opt

@alexcrichton
Copy link
Member

@bors: retyr

On Tue, Aug 23, 2016 at 11:50 AM, bors [email protected] wrote:

💔 Test failed - auto-linux-cross-opt
https://buildbot.rust-lang.org/builders/auto-linux-cross-opt/builds/3422

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#35748 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95EUnHwzaviKYvWh9b0Nf7yBrDlDJks5qi0D_gaJpZM4JmemE
.

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Aug 23, 2016 at 12:38 PM, Alex Crichton [email protected]
wrote:

@bors: retyr

On Tue, Aug 23, 2016 at 11:50 AM, bors [email protected] wrote:

💔 Test failed - auto-linux-cross-opt
https://buildbot.rust-lang.org/builders/auto-linux-cross-opt/builds/3422

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#35748 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD95EUnHwzaviKYvWh9b0Nf7yBrDlDJks5qi0D_gaJpZM4JmemE
.

@bors
Copy link
Collaborator

bors commented Aug 24, 2016

⌛ Testing commit 6aca068 with merge 308824a...

bors added a commit that referenced this pull request Aug 24, 2016
@bors
Auto merge of #35748 - michaelwoerister:fix-rust-gdb-py-version-check…
308824a 
…, r=brson

Make version check in gdb_rust_pretty_printing.py more compatible.

Some versions of Python don't support the `major` field on the object returned by `sys.version_info`.

Fixes #35724

r? @brson
@bors
Copy link
Collaborator

bors commented Aug 24, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: brson
Pushing 308824a to master...

@bors bors merged commit 6aca068 into rust-lang:master Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelwoerister @brson @bors @alexcrichton