Fix linker on Solaris/Illumos #35821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
nbaksalyar
force-pushed
the
solaris-trans-fix
branch
from
bbcad02 to
dfd8b4c
Compare
|
@bors: r+ dfd8b4c680457b70bd1efeefc1d2033d4a23fc4b Thanks! |
nbaksalyar
force-pushed
the
solaris-trans-fix
branch
from
dfd8b4c to
de8bb0c
Compare
|
Whoops, sorry - the build seems to be broken (code seems to be diverged a bit from 1.11). |
|
@bors: r+ de8bb0c0dc73fb47ca567318b88ad0582f65beb2 |
Solaris linker doesn't support the `--retain-symbols-file` option, so this patch provides version scripts as an alternative on that platform.
nbaksalyar
force-pushed
the
solaris-trans-fix
branch
from
de8bb0c to
c08b7b9
Compare
|
Oh well, that's a shame, I missed a single |
|
@bors: r+ |
|
📌 Commit c08b7b9 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 22, 2016
Fix linker on Solaris/Illumos This patch provides a fix for the `GnuLinker::export_symbols` function that currently relies on a `--retain-symbols-file` option which is not supported by the Solaris & Illumos linker. Instead, a [version script](https://www.gnu.org/software/gnulib/manual/html_node/LD-Version-Scripts.html) is used on this platform to achieve the same goal. Here's an example of a similar approach in LLVM's CMake script: https://github.com/llvm-mirror/llvm/blob/master/cmake/modules/AddLLVM.cmake#L88-L94. Perhaps other platforms like OpenBSD could benefit from this as well. /cc @semarie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides a fix for the
GnuLinker::export_symbolsfunction that currently relies on a--retain-symbols-fileoption which is not supported by the Solaris & Illumos linker.Instead, a version script is used on this platform to achieve the same goal. Here's an example of a similar approach in LLVM's CMake script: https://github.com/llvm-mirror/llvm/blob/master/cmake/modules/AddLLVM.cmake#L88-L94.
Perhaps other platforms like OpenBSD could benefit from this as well. /cc @semarie