rustbuild: fix building std for musl targets #36144
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -35,7 +35,7 @@ fn main() { | |||
| println!("cargo:rustc-link-lib=dl"); | |||
| println!("cargo:rustc-link-lib=log"); | |||
| println!("cargo:rustc-link-lib=gcc"); | |||
| } else { | |||
| } else if !target.contains("musl") { | |||
There was a problem hiding this comment.
hold on. we still need to pass these for mips-musl
| } | ||
| } | ||
|
|
||
| /// Copies the crt(1,i,n).o startup objects | ||
| /// | ||
| /// Only required for musl targets that statically link to libc | ||
| fn copy_third_party_objects(build: &Build, target: &str, into: &Path) { | ||
| fn copy_third_party_objects(build: &Build, into: &Path) { |
There was a problem hiding this comment.
Can you change the name here to copy_musl_third_party_object as this only works for musl now?
Done |
|
@bors: r+ This makes me realize we need to move |
|
📌 Commit 25145b2 has been approved by |
|
⌛ Testing commit 25145b2 with merge 8aac9e2... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
@bors: retry On Fri, Sep 2, 2016 at 9:00 AM, bors [email protected] wrote:
|
rustbuild: fix building std for musl targets closes #36143 r? @alexcrichton
closes #36143
r? @alexcrichton