resolve: Fix unused import false positive with item_like_imports
#36276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1063,7 +1056,7 @@ pub struct Resolver<'a> { | |||
| pub maybe_unused_trait_imports: NodeSet, | |||
|
|
|||
| privacy_errors: Vec<PrivacyError<'a>>, | |||
| ambiguity_errors: Vec<(Span, Name, &'a NameBinding<'a>)>, | |||
| ambiguity_errors: Vec<(Span, Name, &'a NameBinding<'a>, &'a NameBinding<'a>)>, | |||
There was a problem hiding this comment.
This is getting complex enough that it should be factored out into a struct
|
r=me with a struct |
jseyfried
force-pushed
the
fix_unused
branch
from
6a854d1 to
ff3a644
Compare
|
@bors r=nrc |
|
📌 Commit ff3a644 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36249.
r? @nrc