Fix issue #36036. #36281
Merged
Fix issue #36036. #36281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @eddyb |
| if pointee.is_sized(tcx, &infcx.parameter_environment, DUMMY_SP) { | ||
| Scalar { value: Pointer, non_zero: non_zero } | ||
| } else { | ||
| let pointee = normalize_associated_type(infcx, pointee); |
There was a problem hiding this comment.
Oh I didn't realize this line was already there, that makes the fix clearer.
|
@bors r+ |
|
📌 Commit 09e6a98 has been approved by |
We were treating an associated type as unsized even when the concrete instantiation was actually sized. Fix is to normalize before checking if it is sized.
pnkfelix
added
the
beta-nominated
|
Seems like a clear case for beta-accepted: one line, fairly trivial change, fixes regression. Marking it as such. cc @rust-lang/compiler |
nikomatsakis
added
the
beta-accepted
Merged
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36036.
We were treating an associated type as unsized even when the concrete instantiation was actually sized. Fix is to normalize before checking if it is sized.