-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustdoc: don't collapse docblock-short
#36293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
liigo
commented
Sep 6, 2016
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I like this, but yeah, seems like it fails the tests. |
Some of the styling of docblock will no longer apply to the docblock-short lines since they change class. Does it matter? I think this one is needed, and maybe more? .docblock {
margin-left: 24px;
} |
9c7d114
to
335a09b
Compare
@steveklabnik I've fixed test failure, and rebased. r? |
@steveklabnik @bluss If remove it, something will get messed: But for |
@liigo Aha, I tested locally and that seems right. Looks like |
I'll recheck. Thank you @bluss ! |
03dbfb8
to
26d5f99
Compare
Done. Could you have another review? Thank you! @bluss |
@bors: r+ thank you! |
📌 Commit 26d5f99 has been approved by |
rustdoc: don't collapse `docblock-short` 
This change looks great in real life 👍 |