Skip to content

remove ExactSizeIterator from RangeInclusive<{u,i}{32,size}> #36395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2016
Merged

remove ExactSizeIterator from RangeInclusive<{u,i}{32,size}> #36395

merged 1 commit into from
Sep 29, 2016

Conversation

durka
Copy link
Contributor

@durka durka commented Sep 11, 2016 •
edited
Loading

Fixes #36386.

This is a [breaking-change] for nightly users of #![feature(inclusive_range_syntax)] and/or #![feature(inclusive_range)].

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@durka durka force-pushed the rangeinclusive-no-esi branch from 205df3d to 45f2a90 Compare September 11, 2016 01:56
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 11, 2016
@durka
Copy link
Contributor Author

durka commented Sep 11, 2016

Note that this is under debate at #36386. Also cc #28237.

@durka durka force-pushed the rangeinclusive-no-esi branch from 45f2a90 to 90ed378 Compare September 11, 2016 20:30
@durka durka changed the title remove ExactSizeIterator from RangeInclusive<u/isize> remove ExactSizeIterator from RangeInclusive<{u,i}{32,size}> Sep 11, 2016
@durka durka force-pushed the rangeinclusive-no-esi branch from 90ed378 to bd1ae63 Compare September 12, 2016 17:07
@brson brson added I-nominated T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 13, 2016
@alexcrichton
Copy link
Member

@bors: r+

Thanks @durka!

@bors
Copy link
Collaborator

bors commented Sep 29, 2016

📌 Commit bd1ae63 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Sep 29, 2016

⌛ Testing commit bd1ae63 with merge eee2d04...

bors added a commit that referenced this pull request Sep 29, 2016
@bors
Auto merge of #36395 - durka:rangeinclusive-no-esi, r=alexcrichton
eee2d04 
remove ExactSizeIterator from RangeInclusive<{u,i}{32,size}>

Fixes #36386.

This is a [breaking-change] for nightly users of `#![feature(inclusive_range_syntax)]` and/or `#![feature(inclusive_range)]`.
@bors
Copy link
Collaborator

bors commented Sep 29, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing eee2d04 to master...

@bors bors merged commit bd1ae63 into rust-lang:master Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@durka @rust-highfive @alexcrichton @bors @brson @bluss